On Tue, Mar 20, 2012 at 5:11 PM, Lee Essen <lee.es...@nowonline.co.uk> wrote: > On 20/03/2012 16:59, Stefan Hajnoczi wrote: >> >> On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen<lee.es...@nowonline.co.uk> >> wrote: >>> >>> On 19 Mar 2012, at 12:32, Andreas Färber wrote: >>> >>>> Am 19.03.2012 13:05, schrieb Lee Essen: >>>> In my original (way-too-long) patch for Illumos I included fixes for >>>> both of the above, the approach I took was to map "bool" to "int" and >>>> "self" >>>> to "_self" in the dtrace part of tracetool. So it should have had no impact >>>> on any non-dtrace stuff. If that seems like a sensible approach I will look >>>> again, and at the linking issues. >> >> That sounds like it can work. >> >> Stefan > > There are only 5 bool's and 4 self's in the whole of the trace-events file > ... is it easier to "fix" in there, or do you think a change to tracetool is > the most appropriate way?
Folks will add more bool and maybe "self" in the future, so updating ./trace-events is not a permanent solution. tracetool has the ability to do two things: 1. It can reject invalid trace-events input. 2. It can fudge the generated trace backend code so that "self" gets turned into "self_", for example. #2 is nice when we can do it without confusing users. I suggest modifying tracetool. You may wish to hold off on this for a week because we're about to merge the Python version of tracetool, which makes it much more portable. Stefan