On Wed, Mar 20, 2024 at 12:45:23AM +0800, Yuan Liu wrote: > add --enable-qpl and --disable-qpl options to enable and disable > the QPL compression method for multifd migration. > > the Query Processing Library (QPL) is an open-source library > that supports data compression and decompression features. > > The QPL compression is based on the deflate compression algorithm > and use Intel In-Memory Analytics Accelerator(IAA) hardware for > compression and decompression acceleration. > > Please refer to the following for more information about QPL > https://intel.github.io/qpl/documentation/introduction_docs/introduction.html > > Signed-off-by: Yuan Liu <yuan1....@intel.com> > Reviewed-by: Nanhai Zou <nanhai....@intel.com> > --- > meson.build | 16 ++++++++++++++++ > meson_options.txt | 2 ++ > scripts/meson-buildoptions.sh | 3 +++ > 3 files changed, 21 insertions(+) > > diff --git a/meson.build b/meson.build > index b375248a76..bee7dcd53b 100644 > --- a/meson.build > +++ b/meson.build > @@ -1200,6 +1200,20 @@ if not get_option('zstd').auto() or have_block > required: get_option('zstd'), > method: 'pkg-config') > endif > +qpl = not_found > +if not get_option('qpl').auto() > + libqpl = cc.find_library('qpl', required: false) > + if not libqpl.found() > + error('libqpl not found, please install it from ' + > + > 'https://intel.github.io/qpl/documentation/get_started_docs/installation.html') > + endif > + libaccel = dependency('libaccel-config', version: '>=4.0.0', > + required: true, > + method: 'pkg-config') > + qpl = declare_dependency(dependencies: [libqpl, libaccel, > + cc.find_library('dl', required: get_option('qpl'))], > + link_args: ['-lstdc++']) > +endif
Are either of these libraries present in any mainstream Linux distro ? If not, then this feature will not get any CI build coverage from QEMU. Needing to manually add '-lstdc++' & '-ldl' is presumably a requirement from 'qpl'. As a future enhancement it would be much better if 'qpl' provided a pkg-config file, so this list of dependencies didn't have to be hardcoded by apps using qpl With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
