> -----Original Message----- > From: Daniel P. Berrangé <berra...@redhat.com> > Sent: Wednesday, March 20, 2024 6:31 PM > To: Liu, Yuan1 <yuan1....@intel.com> > Cc: pet...@redhat.com; faro...@suse.de; qemu-devel@nongnu.org; > hao.xi...@bytedance.com; bryan.zh...@bytedance.com; Zou, Nanhai > <nanhai....@intel.com> > Subject: Re: [PATCH v5 3/7] configure: add --enable-qpl build option > > On Wed, Mar 20, 2024 at 12:45:23AM +0800, Yuan Liu wrote: > > add --enable-qpl and --disable-qpl options to enable and disable > > the QPL compression method for multifd migration. > > > > the Query Processing Library (QPL) is an open-source library > > that supports data compression and decompression features. > > > > The QPL compression is based on the deflate compression algorithm > > and use Intel In-Memory Analytics Accelerator(IAA) hardware for > > compression and decompression acceleration. > > > > Please refer to the following for more information about QPL > > > https://intel.github.io/qpl/documentation/introduction_docs/introduction.h > tml > > > > Signed-off-by: Yuan Liu <yuan1....@intel.com> > > Reviewed-by: Nanhai Zou <nanhai....@intel.com> > > --- > > meson.build | 16 ++++++++++++++++ > > meson_options.txt | 2 ++ > > scripts/meson-buildoptions.sh | 3 +++ > > 3 files changed, 21 insertions(+) > > > > diff --git a/meson.build b/meson.build > > index b375248a76..bee7dcd53b 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -1200,6 +1200,20 @@ if not get_option('zstd').auto() or have_block > > required: get_option('zstd'), > > method: 'pkg-config') > > endif > > +qpl = not_found > > +if not get_option('qpl').auto() > > + libqpl = cc.find_library('qpl', required: false) > > + if not libqpl.found() > > + error('libqpl not found, please install it from ' + > > + > 'https://intel.github.io/qpl/documentation/get_started_docs/installation.h > tml') > > + endif > > + libaccel = dependency('libaccel-config', version: '>=4.0.0', > > + required: true, > > + method: 'pkg-config') > > + qpl = declare_dependency(dependencies: [libqpl, libaccel, > > + cc.find_library('dl', required: get_option('qpl'))], > > + link_args: ['-lstdc++']) > > +endif > > Are either of these libraries present in any mainstream Linux > distro ? If not, then this feature will not get any CI build > coverage from QEMU. > > Needing to manually add '-lstdc++' & '-ldl' is presumably a > requirement from 'qpl'. As a future enhancement it would be > much better if 'qpl' provided a pkg-config file, so this > list of dependencies didn't have to be hardcoded by apps > using qpl > > > With regards, > Daniel
Hi Daniel Thanks for your comments, the QPL has not been integrated into mainstream Linux distro yet, I am actively promoting QPL to support pkg-config file and integrate it into the distributions. The QPL will support these soon, I will use pkg-config in the next version to solve the QPL build dependency issue.
