Hi, In [*] I posted preliminary steps to unify hmp_info_tlb() and hmp_info_mem() after making them per-CPU handler, rather than target-specific method (which break single binary). Since there is no rush and we need to figure the usefulness of 'info tlb/mem' and what we want to do with it, I dropped the series but salvaged these cleanup patches.
Regards, Phil. [*] https://lore.kernel.org/qemu-devel/20240320164055.60319-1-phi...@linaro.org/ Philippe Mathieu-Daudé (21): host/atomic128: Include missing 'qemu/atomic.h' header hw/core: Remove check on NEED_CPU_H in tcg-cpu-ops.h target/i386: Move APIC related code to cpu-apic.c target/i386: Extract x86_dump_mmu() from hmp_info_tlb() target/m68k: Replace qemu_printf() by monitor_printf() in monitor target/m68k: Have dump_ttr() take a @description argument target/m68k: Move MMU monitor commands from helper.c to monitor.c target/microblaze: Prefix MMU API with 'mb_' target/mips: Prefix MMU API with 'mips_' target/nios2: Prefix MMU API with 'nios2_' target/nios2: Move monitor commands to monitor.c target/nios2: Replace qemu_printf() by monitor_printf() in monitor target/ppc: Replace qemu_printf() by monitor_printf() in monitor target/sh4: Extract sh4_dump_mmu() from hmp_info_tlb() target/sparc: Fix string format errors when DEBUG_MMU is defined target/sparc: Replace qemu_printf() by monitor_printf() in monitor target/xtensa: Prefix MMU API with 'xtensa_' target/xtensa: Extract MMU API to new mmu.c/mmu.h files target/xtensa: Simplify dump_mpu() and dump_tlb() target/xtensa: Move monitor commands to monitor.c target/xtensa: Replace qemu_printf() by monitor_printf() in monitor host/include/generic/host/atomic128-cas.h | 2 + host/include/generic/host/atomic128-ldst.h | 2 + include/hw/core/tcg-cpu-ops.h | 2 - target/i386/cpu.h | 7 + target/m68k/cpu.h | 3 +- target/microblaze/mmu.h | 10 +- target/mips/tcg/tcg-internal.h | 2 +- target/nios2/cpu.h | 2 +- target/nios2/mmu.h | 11 +- target/ppc/cpu.h | 2 +- target/sh4/cpu.h | 2 + target/sparc/cpu.h | 2 +- target/xtensa/cpu.h | 32 +- target/xtensa/mmu.h | 95 ++ target/i386/cpu-apic.c | 112 +++ target/i386/cpu-sysemu.c | 77 -- target/i386/mmu.c | 231 +++++ target/i386/monitor.c | 240 ----- target/m68k/helper.c | 223 ----- target/m68k/monitor.c | 225 ++++- target/microblaze/cpu.c | 2 +- target/microblaze/helper.c | 4 +- target/microblaze/mmu.c | 14 +- target/microblaze/op_helper.c | 4 +- target/mips/cpu.c | 2 +- target/mips/tcg/sysemu/tlb_helper.c | 2 +- target/nios2/cpu.c | 2 +- target/nios2/helper.c | 4 +- target/nios2/mmu.c | 34 +- target/nios2/monitor.c | 27 +- target/ppc/mmu_common.c | 147 +-- target/ppc/ppc-qmp-cmds.c | 2 +- target/sh4/monitor.c | 22 +- target/sparc/ldst_helper.c | 26 +- target/sparc/mmu_helper.c | 102 +- target/sparc/monitor.c | 2 +- target/xtensa/cpu.c | 2 +- target/xtensa/mmu.c | 889 +++++++++++++++++ target/xtensa/mmu_helper.c | 1037 +------------------- target/xtensa/monitor.c | 149 ++- target/i386/meson.build | 2 + target/xtensa/meson.build | 1 + 42 files changed, 1943 insertions(+), 1815 deletions(-) create mode 100644 target/xtensa/mmu.h create mode 100644 target/i386/cpu-apic.c create mode 100644 target/i386/mmu.c create mode 100644 target/xtensa/mmu.c -- 2.41.0