Hey, Het,
On Sun, Apr 07, 2024 at 01:21:24PM +0000, Het Gala wrote:
> Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs)
I think I get your intention to provide two fixup patches on top of
migration-next, which indeed would be preferred so that I can squash them
into the patches before the pull.
However please next time use "git commit --fixup" so that a better subject
will be generated, and that'll make my life (and Fabiano's I suppose in the
future) easier because git rebase understand those subjects. Then you
don't need Fixes with an empty commit ID. They'll start with "fixup: XXX"
pointing to a commit with subject rather than commit IDs.
Thanks,
> Signed-off-by: Het Gala <het.g...@nutanix.com>
> ---
> tests/qtest/migration-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index d03a655f83..584d7c496f 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1724,7 +1724,7 @@ static void test_precopy_common(MigrateCommon *args)
> }
>
> if (args->result == MIG_TEST_QMP_ERROR) {
> - migrate_qmp_fail(from, args->connect_uri, args->connect_uri, "{}");
> + migrate_qmp_fail(from, args->connect_uri, args->connect_channels,
> "{}");
> goto finish;
> }
--
Peter Xu
