Hi, I completely agree! This was more of a "NEWCOMERS" issue to help us understand how the patch flow works. I'll take up a trivial issue and work on it instead.
Thanks, Tanmay On Sun, 5 May 2024 at 02:05, Michael Tokarev <m...@tls.msk.ru> wrote: > 04.05.2024 21:58, Tanmay wrote: > > Hi, > > > > I have attached a patch file that fixes indentation and formatting for > some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373 > > <https://gitlab.com/qemu-project/qemu/-/issues/373>. > > it is sort of good you posted this patch to stable@. It has absolutely > nothing to do > with stable, but it serves as a an example of things which should - in my > opinion - > not be done at all. We had another similar change, 55339361276a "sh4: > Coding style: > Remove tabs", which makes all further changes (fixes) in this area > basically > non-back-portable to previous stable series. > > FWIW, > > /mjt > -- > GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. > New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD > 3D98 ECDF 2C8E > Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C > E0A0 8044 65C5 > Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt > >
