Hi, I just sent a patch with fewer files to address using git-send-email.
Thanks, Tanmay On Tue, 7 May 2024 at 15:56, Peter Maydell <peter.mayd...@linaro.org> wrote: > On Mon, 6 May 2024 at 07:20, Tanmay <tanmaynpatil...@gmail.com> wrote: > > > > Hi, > > > > I have added a patch inline that fixes indentation and formatting for > some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373. > > > > Thanks, > > Tanmay > > Hi; thanks for this patch. Unfortunately there seem to be some > problems with the formatting, which mean it doesn't apply correctly. > > In particular you've sent it as a plain/text + HTML email, and > something (probably your mail client) is wrapping long lines. > I can usually fix something like this up on my end for a first > time submitter, but in this case the patch is just way too big > for that to be practical. > > I generally don't recommend trying to send patch emails directly > through the gmail web UI -- it unfortunately mangles them too > much. Personally I use git-send-email; it is a bit awkward to > set up, but https://git-send-email.io/ has a nice step-by-step > guide including specific details on how to configure it to send > via Gmail. > > > From 46026574821c46804111eea6607a1b39314b7abe Mon Sep 17 00:00:00 2001 > > From: Tanmay Patil <tanmaynpatil...@gmail.com> > > Date: Sat, 25 Nov 2023 00:53:54 +0530 > > Subject: [PATCH] Fixes: Indentation using TABs and improve formatting > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/373 > > > > Files changed: > > - hw/arm/boot.c > > - hw/char/omap_uart.c > > - hw/dma/pxa2xx_dma.c > > - hw/gpio/omap_gpio.c > > - hw/gpio/zaurus.c > > - hw/input/tsc2005.c > > - hw/input/tsc210x.c > > - hw/intc/omap_intc.c > > - hw/misc/cbus.c > > - hw/misc/omap_clk.c > > - hw/misc/omap_l4.c > > - hw/misc/omap_sdrc.c > > - hw/misc/omap_tap.c > > - hw/sd/omap_mmc.c > > - hw/sd/pxa2xx_mmci.c > > - hw/timer/omap_gptimer.c > > - hw/timer/omap_synctimer.c > > - hw/timer/pxa2xx_timer.c > > - include/hw/arm/pxa.h > > - include/hw/arm/sharpsl.h > > - include/hw/arm/soc_dma.h > > - tcg/arm/tcg-target.h > > > > Signed-off-by: Tanmay Patil <tanmaynpatil...@gmail.com> > > --- > > hw/arm/boot.c | 8 +- > > hw/char/omap_uart.c | 49 +- > > hw/dma/pxa2xx_dma.c | 198 ++++---- > > hw/gpio/omap_gpio.c | 243 +++++----- > > hw/gpio/zaurus.c | 61 +-- > > hw/input/tsc2005.c | 130 ++--- > > hw/input/tsc210x.c | 442 +++++++++-------- > > hw/intc/omap_intc.c | 261 +++++----- > > hw/misc/cbus.c | 202 ++++---- > > hw/misc/omap_clk.c | 999 +++++++++++++++++++------------------- > > hw/misc/omap_l4.c | 21 +- > > hw/misc/omap_sdrc.c | 135 +++--- > > hw/misc/omap_tap.c | 28 +- > > hw/sd/omap_mmc.c | 208 ++++---- > > hw/sd/pxa2xx_mmci.c | 149 +++--- > > hw/timer/omap_gptimer.c | 126 ++--- > > hw/timer/omap_synctimer.c | 7 +- > > hw/timer/pxa2xx_timer.c | 279 ++++++----- > > include/hw/arm/pxa.h | 100 ++-- > > include/hw/arm/sharpsl.h | 2 +- > > include/hw/arm/soc_dma.h | 4 +- > > tcg/arm/tcg-target.h | 4 +- > > 22 files changed, 1903 insertions(+), 1753 deletions(-) > > This is a lot of changes to do all in one commit, even though they're > all just whitespace fixes. Could you split them up, please, into > multiple patches that tackle fewer files at a time? > > thanks > -- PMM >
