On Wed, May 08, 2024 at 09:44:45AM +0200, Stefano Garzarella wrote:
> On some OS (e.g. macOS) sendmsg() returns -1 (errno EINVAL) if
> the `struct msghdr` has the field `msg_controllen` set to 0, but
> `msg_control` is not NULL.
>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
> Reviewed-by: David Hildenbrand <da...@redhat.com>
> Reviewed-by: Philippe Mathieu-Daud?? <phi...@linaro.org>
Philippe's name has got mangled here
> Signed-off-by: Stefano Garzarella <sgarz...@redhat.com>
> ---
> subprojects/libvhost-user/libvhost-user.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/subprojects/libvhost-user/libvhost-user.c
> b/subprojects/libvhost-user/libvhost-user.c
> index a879149fef..22bea0c775 100644
> --- a/subprojects/libvhost-user/libvhost-user.c
> +++ b/subprojects/libvhost-user/libvhost-user.c
> @@ -632,6 +632,7 @@ vu_message_write(VuDev *dev, int conn_fd, VhostUserMsg
> *vmsg)
> memcpy(CMSG_DATA(cmsg), vmsg->fds, fdsize);
> } else {
> msg.msg_controllen = 0;
> + msg.msg_control = NULL;
> }
>
> do {
> --
> 2.45.0
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
