On Wed, May 08, 2024 at 09:44:48AM +0200, Stefano Garzarella wrote: > In vhost-user-server we set all fd received from the other peer > in non-blocking mode. For some of them (e.g. memfd, shm_open, etc.) > it's not really needed, because we don't use these fd with blocking > operations, but only to map memory. > > In addition, in some systems this operation can fail (e.g. in macOS > setting an fd returned by shm_open() non-blocking fails with errno > = ENOTTY). > > So, let's avoid setting fd non-blocking for those messages that we > know carry memory fd (e.g. VHOST_USER_ADD_MEM_REG, > VHOST_USER_SET_MEM_TABLE). > > Signed-off-by: Stefano Garzarella <sgarz...@redhat.com> > --- > v3: > - avoiding setting fd non-blocking for messages where we have memory fd > (Eric) > --- > util/vhost-user-server.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
