On Thu, 9 May 2024 at 19:17, Cord Amfmgm <dmamf...@gmail.com> wrote: > > > > On Thu, May 9, 2024 at 12:48 PM Peter Maydell <peter.mayd...@linaro.org> > wrote: >> >> On Wed, 8 May 2024 at 16:29, Cord Amfmgm <dmamf...@gmail.com> wrote: >> > On Wed, May 8, 2024 at 3:45 AM Thomas Huth <th...@redhat.com> wrote: >> >> >> >> Your Signed-off-by line does not match the From: line ... could you please >> >> fix this? (see >> >> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line >> >> , too) >> > >> > >> > I'll submit the new patch request with my pseudonym in the From: and >> > Signed-off-by: lines, per your request. Doesn't matter to me. However, >> > this arises simply because I don't give gmail my real name - >> > https://en.wikipedia.org/wiki/Nymwars >> >> I'm confused now. Of the two names you've used in this >> patch (Cord Amfmgm and David Hubbard), are they both >> pseudonyms, or is one a pseudonym and one your real name? >> > > Hi Peter, > > I am attempting to submit a small patch. For context, I'm getting broader > attention now because apparently OHCI is one of the less used components of > qemu and maybe the review process was taking a while. That's relevant because > I wasn't able to get prompt feedback and am now choosing what appears to be > the most expeditious approach -- all I want is to get this patch done and be > out of your hair. If Thomas Huth wants me to use a consistent name, have I > not complied? Are you asking out of curiosity or is there a valid reason why > I should answer your question in order to get the patch submitted? Would you > like to have a friendly chat over virtual coffee sometime (but off-list)? > > If you could please clarify I'm sure the answer is an easy one.
I'm asking because our basic expected position is "commits are from the submitter's actual name, not a pseudonym". Obviously we can't tell if people use a consistent plausible looking pseudonym whether that corresponds to their real-world name or not, but if you have a real name you're happy to attach to this patch and are merely using a pseudonym for Google email, then the resubmit of this patch didn't seem to me to do that. i.e. I was expecting the change to be "make the patch From: match the Signed-off-by line", not "make the Signed-off-by line match the patch From:". (For avoidance of doubt, we don't care about the email From: line, which is distinct from the commit message From: i.e. author.) So I was essentially asking "did you mean to do this, or did you misunderstand what we were asking for?". On the question of the actual patch, I'll try to get to it if Gerd doesn't first (though I have a conference next week so it might be the week after). The main thing I need to chase down is whether it's OK to call usb_packet_addbuf() with a zero length or not. thanks -- PMM
