On Tue, May 14, 2024 at 08:28:27AM +0000, Zhijian Li (Fujitsu) wrote: > > > On 19/04/2024 07:10, nifan....@gmail.com wrote: > > + uint64_t dc_size; > > + > > + mr = host_memory_backend_get_memory(ct3d->dc.host_dc); > > + dc_size = memory_region_size(mr); > > + region_len = DIV_ROUND_UP(dc_size, ct3d->dc.num_regions); > > + > > + if (dc_size % (ct3d->dc.num_regions * CXL_CAPACITY_MULTIPLIER) != 0) { > > + error_setg(errp, "host backend size must be multiples of region > > len"); > > I prefer to have the %region_len% in the error message as well so that i can > update the > backend file accordingly.
Will add. Fan > > > > > + return false; > > + }