On Fri, 24 May 2024 at 00:38, Fabiano Rosas <faro...@suse.de> wrote:
> This is further indicated by the presence of the 'offset'
> argument, which indicates the start of the region where QEMU is
> allowed to write.
>
> Fix the issue by replacing the O_TRUNC flag on open by an ftruncate
> call, which will take the offset into consideration.
>
> + if (ftruncate(fioc->fd, offset)) {
> + error_setg_errno(errp, errno,
> + "failed to truncate migration file to offset %"
> PRIx64,
> + offset);
> + object_unref(OBJECT(fioc));
> + return;
> + }
> +
* Should 'offset' be checked for > zero while ftruncating? Else it'll
be same as O_TRUNC. Otherwise it looks fine.
Reviewed-by: Prasad Pandit <p...@fedoraproject.org>
Thank you.
---
- Prasad
