On 03/27/12 02:24, Jia Liu wrote:
> Add MIPS DSP Branch instruction Support.
> 
> Signed-off-by: Jia Liu <pro...@gmail.com>

Reviewed-by: Richard Henderson <r...@twiddle.net>

> +        case OPC_BPOSGE32:
> +            tcg_gen_setcondi_tl(TCG_COND_GT, bcond, t0, 31);

Nit: It might be better to use TCG_COND_GE ... 32, since that's
both the name of the insn and its official documentation.  Of
course that makes no difference to the correctness.


r~

Reply via email to