On Thu, Jun 06, 2024 at 04:30:09PM +0200, Gerd Hoffmann wrote:
What's the justification for declaring cirrus to be insecure ?
It is shipped as a driver in RHEL for years, was the default graphics
adapter for most of this time, and bugs in it are considered CVEs
still.
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
> hw/display/cirrus_vga.c | 1 +
> hw/display/cirrus_vga_isa.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
> index 150883a97166..1f4c55b21415 100644
> --- a/hw/display/cirrus_vga.c
> +++ b/hw/display/cirrus_vga.c
> @@ -3007,6 +3007,7 @@ static void cirrus_vga_class_init(ObjectClass *klass,
> void *data)
> dc->vmsd = &vmstate_pci_cirrus_vga;
> device_class_set_props(dc, pci_vga_cirrus_properties);
> dc->hotpluggable = false;
> + klass->not_secure = true;
> }
>
> static const TypeInfo cirrus_vga_info = {
> diff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c
> index 84be51670ed8..535a631b4b09 100644
> --- a/hw/display/cirrus_vga_isa.c
> +++ b/hw/display/cirrus_vga_isa.c
> @@ -85,6 +85,7 @@ static void isa_cirrus_vga_class_init(ObjectClass *klass,
> void *data)
> dc->realize = isa_cirrus_vga_realizefn;
> device_class_set_props(dc, isa_cirrus_vga_properties);
> set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> + klass->not_secure = true;
> }
>
> static const TypeInfo isa_cirrus_vga_info = {
> --
> 2.45.2
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
