On Thu, Jun 06, 2024 at 04:30:08PM +0200, Gerd Hoffmann wrote: > The hub supports only USB 1.1. When running out of usb ports it is in > almost all cases the much better choice to add another usb host adapter > (or increase the number of root ports when using xhci) instead of using > the usb hub.
Is that actually a strong enough reason to delete this device though ? This reads like its merely something we don't expect to be commonly used, rather than something we would actively want to delete. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > hw/usb/dev-hub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c > index 06e9537d0356..bc8d0ba4cfcf 100644 > --- a/hw/usb/dev-hub.c > +++ b/hw/usb/dev-hub.c > @@ -686,6 +686,7 @@ static void usb_hub_class_initfn(ObjectClass *klass, void > *data) > set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); > dc->fw_name = "hub"; > dc->vmsd = &vmstate_usb_hub; > + klass->deprecated = true; > device_class_set_props(dc, usb_hub_properties); > } Deprecations should also have an entry in docs/about/deprecated.rst to warn users about the intent to delete the code in future. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
