Re: [PATCH v15 12/14] virtio-gpu: Handle resource blob commands

[Akihiko Odaki]

On 2024/06/23 6:55, Dmitry Osipenko wrote:

From: Antonio Caggiano <antonio.caggi...@collabora.com>

Support BLOB resources creation, mapping and unmapping by calling the
new stable virglrenderer 0.10 interface. Only enabled when available and
via the blob config. E.g. -device virtio-vga-gl,blob=true

Signed-off-by: Antonio Caggiano <antonio.caggi...@collabora.com>
Signed-off-by: Xenia Ragiadakou <xenia.ragiada...@amd.com>
Signed-off-by: Huang Rui <ray.hu...@amd.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipe...@collabora.com>
---
  hw/display/virtio-gpu-gl.c     |   3 +
  hw/display/virtio-gpu-virgl.c  | 334 +++++++++++++++++++++++++++++++--
  hw/display/virtio-gpu.c        |   6 +-
  include/hw/virtio/virtio-gpu.h |   2 +
  4 files changed, 330 insertions(+), 15 deletions(-)

diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c
index 4fe9e6a0c21c..5f27568d3ec8 100644
--- a/hw/display/virtio-gpu-gl.c
+++ b/hw/display/virtio-gpu-gl.c
@@ -160,6 +160,9 @@ static void virtio_gpu_gl_device_unrealize(DeviceState 
*qdev)
      VirtIOGPUGL *gl = VIRTIO_GPU_GL(qdev);

if (gl->renderer_state >= RS_INITED) {

+#if VIRGL_VERSION_MAJOR >= 1
+        qemu_bh_delete(gl->cmdq_resume_bh);
+#endif
          if (virtio_gpu_stats_enabled(g->parent_obj.conf)) {
              timer_free(gl->print_stats);
          }
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
index 60befab7efc2..f6cb4fe5b28e 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/display/virtio-gpu-virgl.c
@@ -26,6 +26,7 @@

struct virtio_gpu_virgl_resource {

      struct virtio_gpu_simple_resource base;
+    MemoryRegion *mr;
  };

static struct virtio_gpu_virgl_resource *

@@ -49,6 +50,152 @@ virgl_get_egl_display(G_GNUC_UNUSED void *cookie)
  }
  #endif

+#if VIRGL_VERSION_MAJOR >= 1

+typedef enum {
+    HOSTMEM_MR_UNMAPPING,
+    HOSTMEM_MR_FINISH_UNMAPPING,
+} HostmemMRState;

Now you can make it a mere bool.