Hi Felix,
On 24/6/24 22:43, Felix Wu wrote:
From: Roman Kiryanov <r...@google.com>
'class' is a C++ keyword and it prevents from
using the QEMU headers with a C++ compiler.
Google-Bug-Id: 331190993
I asked Roman twice about this tag meaning:
https://lore.kernel.org/qemu-devel/e865d8e3-e768-4b1f-86d3-aeabe8f1d...@linaro.org/
https://lore.kernel.org/qemu-devel/09b7e7e1-30a6-49d0-a5f8-9cfc62884...@linaro.org/
Since you are taking his work, do you mind clarifying?
Please include a cover letter for your series:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#include-a-meaningful-cover-letter
Also for headers refactors, enabling scripts/git.orderfile helps
reviewers.
Since you are posting different C++ enablement cleanups,
I suggest you add a section in our docs/devel/style.rst
requesting to keep headers C++ compatible, by not using
C++ reserved keywords, etc...
In particular because the mainstream project is not build-testing
for C++, thus we will likely merge patches breaking C++ and
make your life harder. That said, a C++ header smoke-build job
in our CI could help.
Change-Id: I9ab7d2d77edef654a9c7b7cb9cd01795a6ed65a2
Signed-off-by: Felix Wu <f...@google.com>
Signed-off-by: Roman Kiryanov <r...@google.com>
---
hw/core/qdev-properties-system.c | 2 +-
include/exec/memory.h | 2 +-
include/qom/object.h | 2 +-
qom/object.c | 90 ++++++++++++++++----------------
4 files changed, 48 insertions(+), 48 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 13d3a655dd..7afdb261a8 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -153,7 +153,7 @@ struct ObjectClass
struct Object
{
/* private: */
- ObjectClass *class;
+ ObjectClass *klass;
ObjectFree *free;
GHashTable *properties;
uint32_t ref;
I suppose the OBJECT_CLASS / OBJECT_CLASS_CHECK / OBJECT_GET_CLASS
macros aren't compiled so "class" isn't a problem there.
Since it isn't worst than our INTERFACE_CLASS() use:
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Regards,
Phil.
