On Thu, 27 Jun 2024 08:44:14 -0400 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Thu, Jun 27, 2024 at 02:42:44PM +0200, Igor Mammedov wrote: > > On Thu, 20 Jun 2024 17:03:11 +0100 > > Jonathan Cameron <jonathan.came...@huawei.com> wrote: > > > > > Rather than attempting to create a generic function with mess of the two > > > different device handle types, use a PCI handle specific variant. If the > > > ACPI handle form is needed then that can be introduced alongside this > > > with little duplicated code. > > > > > > Drop the PCIDeviceHandle in favor of just passing the bus, devfn > > > and segment directly. devfn kept as a single byte because ARI means > > > that in cases this is just an 8 bit function number. > > > > > > Suggested-by: Igor Mammedov <imamm...@redhat.com> > > > Link: > > > https://lore.kernel.org/qemu-devel/20240618142333.102be...@imammedo.users.ipa.redhat.com/ > > > Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> > > > > with typo fixed > > typo being "in cases"? > > > Reviewed-by: Igor Mammedov <imamm...@redhat.com> > > > nope, I highlighted it the patch > +void build_srat_pci_generic_initiator(GArray * table_date, int node, s/table_date/table_data/
