On 7/1/24 06:30, Daniel Henrique Barboza wrote:
We're allowing multiple -accel options to be used with different
accelerators, even though we don't have any machine that supports mixed
acceleration.

In fact, it will only parse the first occurence of -accel and, aside
from a help option (e.g. -accel help) that will always cause the process
to print the help text, it will accept every other accel option
regardless of being correct or not. E.g. this:

qemu-system-x86_64 -accel kvm -accel tcg -accel IamNotAnAccel (...)

will happily boot a x86_64 KVM guest.

Do not allow for different accelerators to be used when multiple
instances of -accel are present.

Cc: Paolo Bonzini<pbonz...@redhat.com>
Cc: Thomas Huth<th...@redhat.com>
Signed-off-by: Daniel Henrique Barboza<dbarb...@ventanamicro.com>
---
  system/vl.c | 15 ++++++++++++++-
  1 file changed, 14 insertions(+), 1 deletion(-)

We use '-accel kvm -accel tcg' to allow kvm to fail (e.g. no /dev/kvm permission) and proceed with tcg.

This patch will cause testsuite failures.


r~

Reply via email to