On Fri, Jul 05, 2024 at 05:03:17AM +0000, CLEMENT MATHIEU--DRIF wrote:
> From: Clément Mathieu--Drif <clement.mathieu--d...@eviden.com>
>
> VTDIOTLBPageInvInfo.mask might not fit in an uint8_t.
I think what you mean is that is assigned values that might not
fit .... it's u8 ATM so of course it fits.
> Moreover, this field is used in binary operations with 64-bit addresses.
So what?
>
> Signed-off-by: Clément Mathieu--Drif <clement.mathieu--d...@eviden.com>
> ---
> hw/i386/intel_iommu_internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
> index cbc4030031..5fcbe2744f 100644
> --- a/hw/i386/intel_iommu_internal.h
> +++ b/hw/i386/intel_iommu_internal.h
> @@ -436,7 +436,7 @@ struct VTDIOTLBPageInvInfo {
> uint16_t domain_id;
> uint32_t pasid;
> uint64_t addr;
> - uint8_t mask;
> + uint64_t mask;
> };
> typedef struct VTDIOTLBPageInvInfo VTDIOTLBPageInvInfo;
>
> --
> 2.45.2
