Re: [PATCH v16 02/13] hw/ppc/spapr_pci: Do not create DT for disabled PCI device

[Cédric Le Goater]

Hello,

Adding :
  Harsh for QEMU/PPC pseries machine,
  Shivaprasad for KVM/PPC VFIO and IOMMU support.

Could you please give us your feedback on these changes ?

Thanks,

C.

 

 On 9/13/24 05:44, Akihiko Odaki wrote:
Disabled means it is a disabled SR-IOV VF or it is powered off, and
hidden from the guest.

Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
---
  hw/ppc/spapr_pci.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 7cf9904c3546..f63182a03c41 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1296,6 +1296,10 @@ static void spapr_dt_pci_device_cb(PCIBus *bus, 
PCIDevice *pdev,
          return;
      }
  
+    if (!pdev->enabled) {
+        return;
+    }
+
      err = spapr_dt_pci_device(p->sphb, pdev, p->fdt, p->offset);
      if (err < 0) {
          p->err = err;