Marc-André Lureau <marcandre.lur...@redhat.com> writes: > Hi > > On Wed, Oct 2, 2024 at 10:21 AM Markus Armbruster <arm...@redhat.com> wrote:
[...] >> Two ways to fix: >> >> 1. Find all callers that don't, and fix them. Your first hunk is then >> superfluous. Your second hunk fixes the one you already found. >> > > Imho, that's not a good API, it's easy to get wrong. > >> 2. Change the contract so callers don't have to initialize. Your second >> hunk is then superfluous. The update to the contract is missing. >> > > I prefer that it always set the variable. I also prefer that caller > initializes variables. So all are good practices imho, even if it's a > bit redundant. Since you're doing the work to fix the bug, you get first dibs on how to fix it :) [...]
