On Sun, Apr 22, 2012 at 09:56:09PM +0200, Andreas Färber wrote: > Am 20.04.2012 17:44, schrieb Peter Portante: > > Signed-off-by: Peter Portante <peter.porta...@redhat.com> > > Fix itself looks okay, but author, maintainer and qemu-ppc were missing > in CC, and a better commit message would be: > > ---8<--- > pseries: Fix use of global CPU state > > Commit ed120055c7f9b26b5707d3ceabbe5a3f06aaf937 (Implement PAPR VPA > functions for pSeries shared processor partitions) introduced the > register_dtl() function and typo "emv" as name of its argument. > This went unnoticed because the code in that function can access the > global variable "env" so that no build failure resulted. > > Fix the argument to read "env". Resolves LP#986241.
Ouch. Good catch. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson