On Sun, Apr 22, 2012 at 3:56 PM, Andreas Färber <afaer...@suse.de> wrote:
> Am 20.04.2012 17:44, schrieb Peter Portante:
> > Signed-off-by: Peter Portante <peter.porta...@redhat.com>
>
> Fix itself looks okay, but author, maintainer and qemu-ppc were missing
> in CC, and a better commit message would be:
>
> ---8<---
> pseries: Fix use of global CPU state
>
> Commit ed120055c7f9b26b5707d3ceabbe5a3f06aaf937 (Implement PAPR VPA
> functions for pSeries shared processor partitions) introduced the
> register_dtl() function and typo "emv" as name of its argument.
> This went unnoticed because the code in that function can access the
> global variable "env" so that no build failure resulted.
>
> Fix the argument to read "env". Resolves LP#986241.
> ---8<---
>
>
Resubmitted this patch, subject: .[Patch v2] pseries: Fix use of global CPU
state
Thanks,
-peter
> Andreas
>
> > ---
> > hw/spapr_hcall.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c
> > index 634763e..94bb504 100644
> > --- a/hw/spapr_hcall.c
> > +++ b/hw/spapr_hcall.c
> > @@ -482,7 +482,7 @@ static target_ulong register_dtl(CPUPPCState *env,
> target_ulong addr)
> > return H_SUCCESS;
> > }
> >
> > -static target_ulong deregister_dtl(CPUPPCState *emv, target_ulong addr)
> > +static target_ulong deregister_dtl(CPUPPCState *env, target_ulong addr)
> > {
> > env->dispatch_trace_log = 0;
> > env->dtl_size = 0;
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>
>
