On Wed, Jan 08, 2025 at 09:14:35AM -0600, Reza Arbab wrote: > On Wed, Dec 18, 2024 at 11:37:05AM +0100, David Hildenbrand wrote: > > No expert on any of that MSi-X / PCI magic, but LGTM > > > > Acked-by: David Hildenbrand <[email protected]> > > Thanks David! > > Did anyone else have any comments? Just want to make sure I have things in > order to get this into the next release.
Causes a CI failure: https://gitlab.com/mstredhat/qemu/-/jobs/8800804175 In file included from ../hw/virtio/virtio-balloon-pci.c:15: ../hw/virtio/virtio-balloon-pci.c: In function ‘virtio_balloon_pci_class_init’: ../include/qemu/osdep.h:261:35: error: call to ‘qemu_build_not_reached_always’ declared with attribute error: code path is reachable 261 | #define qemu_build_not_reached() qemu_build_not_reached_always() | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../include/hw/qdev-core.h:956:13: note: in expansion of macro ‘qemu_build_not_reached’ 956 | qemu_build_not_reached(); \ | ^~~~~~~~~~~~~~~~~~~~~~ ../hw/virtio/virtio-balloon-pci.c:69:5: note: in expansion of macro ‘device_class_set_props’ 69 | device_class_set_props(dc, virtio_balloon_properties); | ^~~~~~~~~~~~~~~~~~~~~~ [2493/4296] Compiling C object libqemu-ppc64-softmmu.a.p/hw_virtio_virtio-scsi-pci.c.o [2494/4296] Compiling C object libqemu-ppc64-softmmu.a.p/hw_virtio_virtio-9p-pci.c.o > -- > Reza Arbab
