Re: [PATCH] virtio-balloon-pci: Allow setting nvectors, so we can use MSI-X

[Reza Arbab]

On Wed, Jan 15, 2025 at 10:06:26AM +0100, Philippe Mathieu-Daudé wrote:
--- a/hw/virtio/virtio-balloon-pci.c
+++ b/hw/virtio/virtio-balloon-pci.c
@@ -35,11 +35,23 @@ struct VirtIOBalloonPCI {
     VirtIOBalloon vdev;
 };
+static Property virtio_balloon_properties[] = {
+    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags,
+                    VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
+    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors,
+                       DEV_NVECTORS_UNSPECIFIED),
+    DEFINE_PROP_END_OF_LIST(),

You shouldn't use that anymore since commit 5fcabe628b8
("include/hw/qdev-properties: Remove DEFINE_PROP_END_OF_LIST").

Ah, yes, that happened after I sent this.

Also, this array can be declared const.

Funny, commit 1577a9180f37 ("hw/virtio: Constify all Property") also 
happened not long after I sent.

Thanks for your review! v2 incoming.

--
Reza Arbab