Hi,
This fix definition of some classes with wrong parent.
Used below script to get a list, hoping all are addressed.
find "$directory" -type d \( -name "roms" -o -name "build" \) -prune -o -type f
\( -name "*.c" -o -name "*.h" \) -print | while read -r file; do
awk '/^(struct |typedef struct )/ {
first = $0;
getline second;
getline third;
if (first ~ /[Cc]lass/ && !(second ~ /Class/) && !(third ~ /Class/)) {
print FILENAME ":" NR-2 ": " first;
print FILENAME ":" NR-1 ": " second;
print FILENAME ":" NR ": " third;
}
}' "$file"
done
patch4/5 are more like cleanups instead of fixes as those class_size are not
initialized so class definition doesn't take effect, so no Fixes tag for them.
Thanks
Zhenzhong
Changelog:
v4:
- add comments 'this isn't catastrophic only because sizeof(VirtIODevice) >
sizeof(VirtioDeviceClass).' to patch1/2/3 (Markus)
- collect RB for patch5
v3:
- s/Suggested-by/Reported-by on patch2 (David)
- add Closes: tag (David)
- collect RB
v2:
- add more fixes per David
Zhenzhong Duan (5):
virtio-mem: Fix definition of VirtIOMEMClass
virtio-pmem: Fix definition of VirtIOPMEMClass
hw/gpio/aspeed: Fix definition of AspeedGPIOClass
hw/char/sh_serial: Remove dummy definition of SH_SERIAL class
hw/riscv/riscv-iommu: Remove definition of RISCVIOMMU[Pci|Sys]Class
include/hw/gpio/aspeed_gpio.h | 2 +-
include/hw/riscv/iommu.h | 6 ++----
include/hw/virtio/virtio-mem.h | 2 +-
include/hw/virtio/virtio-pmem.h | 2 +-
hw/char/sh_serial.c | 4 +---
hw/riscv/riscv-iommu-pci.c | 6 ------
hw/riscv/riscv-iommu-sys.c | 6 ------
7 files changed, 6 insertions(+), 22 deletions(-)
--
2.34.1