On Wed, 1 Oct 2025, Philippe Mathieu-Daudé wrote:
Instead of using the convenient @CPUState::as shortcut, use
I'm not sure convenient in English means what you meant here at least it's not clear to me what you mean. Does this make it more inconvenient? Maybe you need a different word here.
cpu_get_address_space(asidx=0) to get the vCPU first address
Could you move cpu_get_address_space() to the header and make it inline? I know you had another series to reduce inline functions but this is just one line and won't be inlined by the compiler unless it's defined in the header. I don't know if this is relevant but it keeps closer to the current behaviour.
Regards, BALATON Zoltan
space. The goal is to reduce the risk of AS mis-use for targets that uses multiple ASes per vCPU. Based-on: <[email protected]> Philippe Mathieu-Daudé (22): system/qtest: Use &address_space_memory for first vCPU address space disas/disas-mon: Get cpu first addr space with cpu_get_address_space() monitor/hmp-cmds: Get cpu first addr space with cpu_get_address_space() hw/core/loader: Get cpu first addr space with cpu_get_address_space() hw/ppc: Get cpu first addr space with cpu_get_address_space() hw/m86k: Get cpu first addr space with cpu_get_address_space() target/xtensa: Get cpu first addr space with cpu_get_address_space() target/riscv: Get cpu first addr space with cpu_get_address_space() semihosting: Get cpu first addr space with cpu_get_address_space() target/alpha: Get cpu first addr space with cpu_get_address_space() target/arm: Get cpu first addr space with cpu_get_address_space() target/hppa: Get cpu first addr space with cpu_get_address_space() target/i386: Get cpu first addr space with cpu_get_address_space() target/loongarch: Get cpu first addr space with cpu_get_address_space() target/m68k: Get cpu first addr space with cpu_get_address_space() target/microblaze: Get cpu first addr space with cpu_get_address_space() target/ppc: Get cpu first addr space with cpu_get_address_space() target/s390x: Get cpu first addr space with cpu_get_address_space() target/sparc: Get cpu first addr space with cpu_get_address_space() hw/core/cpu: Remove @CPUState::as field exec/cpu: Declare cpu_memory_rw_debug() in 'hw/core/cpu.h' and document target/sparc: Reduce inclusions of 'exec/cpu-common.h' include/exec/cpu-common.h | 4 --- include/hw/core/cpu.h | 23 +++++++++++-- target/ppc/mmu-hash32.h | 12 ++++--- target/sparc/cpu.h | 1 - disas/disas-mon.c | 3 +- hw/core/cpu-common.c | 1 - hw/core/generic-loader.c | 5 +-- hw/intc/spapr_xive.c | 5 +-- hw/m68k/mcf5208.c | 6 ++-- hw/m68k/q800.c | 17 ++++++---- hw/m68k/virt.c | 5 +-- hw/ppc/pegasos2.c | 2 +- hw/ppc/spapr.c | 12 +++---- hw/ppc/spapr_hcall.c | 55 ++++++++++++++++--------------- hw/ppc/spapr_iommu.c | 4 +-- hw/ppc/spapr_nested.c | 43 +++++++++++++----------- monitor/hmp-cmds-target.c | 3 +- semihosting/arm-compat-semi.c | 4 ++- system/cpus.c | 2 +- system/physmem.c | 10 ------ system/qtest.c | 27 +++++++-------- target/alpha/helper.c | 8 +++-- target/arm/cpu.c | 7 ++-- target/hppa/int_helper.c | 3 +- target/i386/arch_memory_mapping.c | 10 +++--- target/loongarch/cpu_helper.c | 5 +-- target/loongarch/tcg/tlb_helper.c | 7 ++-- target/m68k/helper.c | 28 ++++++++-------- target/microblaze/op_helper.c | 6 ++-- target/ppc/excp_helper.c | 4 +-- target/ppc/mmu-book3s-v3.c | 5 +-- target/ppc/mmu-hash32.c | 6 ++-- target/ppc/mmu-hash64.c | 12 ++++--- target/ppc/mmu-radix64.c | 13 ++++---- target/riscv/cpu_helper.c | 7 ++-- target/s390x/cpu-system.c | 4 ++- target/s390x/mmu_helper.c | 9 ++--- target/s390x/tcg/excp_helper.c | 10 +++--- target/s390x/tcg/mem_helper.c | 6 ++-- target/sparc/helper.c | 1 + target/sparc/int64_helper.c | 1 + target/sparc/ldst_helper.c | 22 +++++++------ target/sparc/mmu_helper.c | 21 +++++++----- target/xtensa/mmu_helper.c | 3 +- 44 files changed, 253 insertions(+), 189 deletions(-)
