Markus Armbruster <[email protected]> writes:
> Zhao Liu <[email protected]> writes:
>
>> From: Zhao Liu <[email protected]>
>>
>> Add "modules" parameter parsing support in -smp.
>>
>> Suggested-by: Xiaoyao Li <[email protected]>
>> Tested-by: Yongwei Ma <[email protected]>
>> Signed-off-by: Zhao Liu <[email protected]>
>
> QAPI schema
> Acked-by: Markus Armbruster <[email protected]>
I missed something. The patch added @modules without updating "The
ordering from ...":
##
# @SMPConfiguration:
#
# Schema for CPU topology configuration. A missing value lets QEMU
# figure out a suitable value based on the ones that are provided.
#
# The members other than @cpus and @maxcpus define a topology of
# containers.
#
--> # The ordering from highest/coarsest to lowest/finest is: @drawers,
--> # @books, @sockets, @dies, @clusters, @cores, @threads.
Where does it go in this list?
The order below suggests between @clusters and @modules.
#
# Different architectures support different subsets of topology
# containers.
#
# For example, s390x does not have clusters and dies, and the socket
# is the parent container of cores.
#
# @cpus: number of virtual CPUs in the virtual machine
#
# @maxcpus: maximum number of hotpluggable virtual CPUs in the virtual
# machine
#
# @drawers: number of drawers in the CPU topology (since 8.2)
#
# @books: number of books in the CPU topology (since 8.2)
#
# @sockets: number of sockets per parent container
#
# @dies: number of dies per parent container
#
# @clusters: number of clusters per parent container (since 7.0)
#
# @modules: number of modules per parent container (since 9.1)
#
# @cores: number of cores per parent container
#
# @threads: number of threads per core
#
# Since: 6.1
##
