On Thu, Oct 09, 2025 at 01:40:36PM +0200, Markus Armbruster wrote: > Date: Thu, 09 Oct 2025 13:40:36 +0200 > From: Markus Armbruster <[email protected]> > Subject: Re: [PATCH v9 02/21] hw/core/machine: Support modules in -smp > > Markus Armbruster <[email protected]> writes: > > > Zhao Liu <[email protected]> writes: > > > >> From: Zhao Liu <[email protected]> > >> > >> Add "modules" parameter parsing support in -smp. > >> > >> Suggested-by: Xiaoyao Li <[email protected]> > >> Tested-by: Yongwei Ma <[email protected]> > >> Signed-off-by: Zhao Liu <[email protected]> > > > > QAPI schema > > Acked-by: Markus Armbruster <[email protected]> > > I missed something. The patch added @modules without updating "The > ordering from ...": > > ## > # @SMPConfiguration: > # > # Schema for CPU topology configuration. A missing value lets QEMU > # figure out a suitable value based on the ones that are provided. > # > # The members other than @cpus and @maxcpus define a topology of > # containers. > # > --> # The ordering from highest/coarsest to lowest/finest is: @drawers, > --> # @books, @sockets, @dies, @clusters, @cores, @threads. > > Where does it go in this list? > > The order below suggests between @clusters and @modules.
Thanks Markus! I missed this case... sorry for that. And you're right, @module is between @clusters and @modules. I'll submit a patch to fix this doc! Regards, Zhao
