Loop in more Nuvoton folks. -----Original Message----- From: Peter Maydell <[email protected]> Sent: Friday, September 26, 2025 12:42 AM To: Yubin Zou <[email protected]> Cc: [email protected]; Paolo Bonzini <[email protected]>; CS20 KFTing <[email protected]>; Hao Wu <[email protected]>; [email protected]; Titus Rwantare <[email protected]> Subject: Re: [PATCH 4/7] hw/pci-host: add Nuvoton PCIe root port
CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content. On Tue, 9 Sept 2025 at 23:11, Yubin Zou <[email protected]> wrote: > > From: Titus Rwantare <[email protected]> > > Signed-off-by: Titus Rwantare <[email protected]> > --- a/hw/pci-host/npcm_pcierc.c > +++ b/hw/pci-host/npcm_pcierc.c > @@ -203,6 +203,7 @@ static void npcm_pcierc_write_window(NPCMPCIERCState *s, > hwaddr addr, > npcm_pcie_update_window_maps(s); > } > > +/* read root complex configuration registers */ > static uint64_t npcm_pcierc_cfg_read(void *opaque, hwaddr addr, > unsigned size) { > NPCMPCIERCState *s = NPCM_PCIERC(opaque); @@ -248,6 +249,7 @@ > static uint64_t npcm_pcierc_cfg_read(void *opaque, hwaddr addr, unsigned size) > return ret; > } > > +/* write root complex configuration registers */ > static void npcm_pcierc_cfg_write(void *opaque, hwaddr addr, uint64_t data, > unsigned size) { These comments look like they should have been in a previous patch where the functions were added. thanks -- PMM ________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
