On Tue, 14 Oct 2025 at 21:15, Richard Henderson <[email protected]> wrote: > > Rename the existing add_cpreg_to_hashtable_aa64 as *_1. > Introduce a new add_cpreg_to_hashtable_aa64 that handles > 128-bit and 64-bit views of an AArch64 system register. > > Signed-off-by: Richard Henderson <[email protected]> > --- > target/arm/helper.c | 61 ++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 57 insertions(+), 4 deletions(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 3b06704963..c240edf182 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -7668,11 +7668,9 @@ static void add_cpreg_to_hashtable_aa32(ARMCPU *cpu, > ARMCPRegInfo *r) > } > } > > -static void add_cpreg_to_hashtable_aa64(ARMCPU *cpu, ARMCPRegInfo *r) > +static void add_cpreg_to_hashtable_aa64_1(ARMCPU *cpu, ARMCPRegInfo *r, > + uint32_t key)
I prefer "do_foo()" over "foo_1()" for naming this kind of "internal part of some other function", and we have a lot more do_foo than foo_1 in target/arm. Otherwise Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
