On Mon, Oct 27, 2025 at 03:55:30PM +0800, Xiaoyao Li wrote: > Date: Mon, 27 Oct 2025 15:55:30 +0800 > From: Xiaoyao Li <[email protected]> > Subject: Re: [PATCH v3 09/20] i386/cpu: Fix supervisor xstate initialization > > On 10/24/2025 2:56 PM, Zhao Liu wrote: > > From: Chao Gao <[email protected]> > > > > Arch lbr is a supervisor xstate, but its area is not covered in > > x86_cpu_init_xsave(). > > > > Fix it by checking supported xss bitmap. > > > > In addition, drop the (uint64_t) type casts for supported_xcr0 since > > x86_cpu_get_supported_feature_word() returns uint64_t so that the cast > > is not needed. Then ensure line length is within 90 characters. > > > > Tested-by: Farrah Chen <[email protected]> > > Signed-off-by: Chao Gao <[email protected]> > > Co-developed-by: Zhao Liu <[email protected]> > > Signed-off-by: Zhao Liu <[email protected]> > > --- > > target/i386/cpu.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index 5cd335bb5574..1917376dbea9 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -9707,20 +9707,23 @@ static void x86_cpu_post_initfn(Object *obj) > > static void x86_cpu_init_xsave(void) > > { > > static bool first = true; > > - uint64_t supported_xcr0; > > + uint64_t supported_xcr0, supported_xss; > > int i; > > if (first) { > > first = false; > > supported_xcr0 = > > - ((uint64_t) x86_cpu_get_supported_feature_word(NULL, > > FEAT_XSAVE_XCR0_HI) << 32) | > > + x86_cpu_get_supported_feature_word(NULL, FEAT_XSAVE_XCR0_HI) | > > missing the "<< 32" here,
Yes, good catch.
