Coverity complains because we assign to ret here but then never read it again before we overwrite it with the call to set_x64_registers().
Analyzed-by: Peter Maydell <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> --- target/i386/mshv/mshv-cpu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 1f7b9cb37ec..1c3db02188c 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -1489,6 +1489,10 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info) reg_values[0] = info->rsi; } else { ret = handle_pio_str_read(cpu, info, repeat, port, direction_flag); + if (ret < 0) { + error_report("Failed to handle pio str read"); + return -1; + } reg_names[0] = HV_X64_REGISTER_RDI; reg_values[0] = info->rdi; } -- 2.51.1
