On 06/05/12 23:13, Paolo Bonzini wrote: > There is one small mistake that needs to be addressed in a v2, so it > would be great if you could use the int*_t visitors to avoid > complicating the code with range checks.
OK so this is what I see: (a) add < 0 checks to <http://patchwork.ozlabs.org/patch/150427/> and include it in the series, (b) make all Netdev integer types as strict as possible, remove superfluous checks, (c) render NetLegacy::name optional. How do I lay out (a)? Should I include the patch verbatim first (with proper From: and Signed-off-by: lines) and then modify it in a small followup, or squash those two and... what? :) Thanks, Laszlo