Il 22/05/2012 12:45, Laszlo Ersek ha scritto: > Inspired by [1], the first half of this series attempts to implement a new > visitor that should clean up defining and processing command line options. > For a more detailed description, please see "[PATCH 04/16] qapi: introduce > OptsVisitor". > > The second half converts -net/-netdev parsing to the new visitor. > > The series depends on "qapi: convert netdev_add & netdev_del" v5, see [2]. > > Comments highly appreciated; please keep me CC'd. Thank you. > > [1] http://lists.nongnu.org/archive/html/qemu-devel/2012-04/msg02512.html > [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg02841.html > > Laszlo Ersek (15): > qapi: introduce "size" type > expose QemuOpt and QemuOpts struct definitions to interested parties > qapi: introduce OptsVisitor > qapi schema: remove trailing whitespace > qapi schema: add Netdev types > hw, net: "net_client_type" -> "NetClientOptionsKind" (qapi-generated) > convert net_client_init() to OptsVisitor > convert net_init_nic() to NetClientOptions > convert net_init_dump() to NetClientOptions > convert net_init_slirp() to NetClientOptions > convert net_init_socket() to NetClientOptions > convert net_init_vde() to NetClientOptions > convert net_init_tap() to NetClientOptions > convert net_init_bridge() to NetClientOptions > remove unused QemuOpts parameter from net init functions > > Paolo Bonzini (1): > qapi: fix error propagation
There is one small mistake that needs to be addressed in a v2, so it would be great if you could use the int*_t visitors to avoid complicating the code with range checks. Otherwise very nice, sorry for the time it took me to do the review. Paolo