On 12/18/25 01:31, Philippe Mathieu-Daudé wrote:
stl_phys_notdirty() is supposed to do an optimized CODE
path store. Here we update the page table via the DATA
path, so can use the normal stl_phys() helper.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
target/sparc/mmu_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c
index 217580a4d8c..46bf500ea83 100644
--- a/target/sparc/mmu_helper.c
+++ b/target/sparc/mmu_helper.c
@@ -189,7 +189,7 @@ static int get_physical_address(CPUSPARCState *env,
CPUTLBEntryFull *full,
if (is_dirty) {
pde |= PG_MODIFIED_MASK;
}
- stl_phys_notdirty(cs->as, pde_ptr, pde);
+ stl_phys(cs->as, pde_ptr, pde);
}
/* the page can be put in the TLB */
I didn't recall that we had this in Sparc.
I suspect that this needs to be reorganized to use atomic operations, like arm.
That said, there's nothing we need from notdirty.
Reviewed-by: Richard Henderson <[email protected]>
r~
