On 12/18/25 01:31, Philippe Mathieu-Daudé wrote:
When the MemTxAttrs value is not specified and no MemTxResult
provided, address_space_ld/st() is equivalent to the simpler
ld/st_phys() API variant. Use the latter.
The _notdirty() variant is supposed to/not/ mark the updated
CODE page as dirty, to not re-translate it. However this code
is only used with the '-kernel' CLI option after the machine
is created and/before/ the vCPUs run, and*only* during the
first (cold) reset; not during following (hot) resets. The
optimisation is totally not justified, since we haven't
translated any guest code yet. Replace by the normal stl_phys()
helper.
Suggested-by: Richard Henderson<[email protected]>
Signed-off-by: Philippe Mathieu-Daudé<[email protected]>
---
hw/arm/aspeed.c | 3 +--
hw/arm/boot.c | 6 ++----
2 files changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <[email protected]>
r~
