On Wed, Dec 10, 2025 at 01:37:25PM +0000, Shameer Kolothum wrote:
> +bool iommufd_backend_viommu_mmap(IOMMUFDBackend *be, uint32_t viommu_id,
> + uint64_t size, off_t offset, void **out_ptr,
> + Error **errp)
> +{
> + g_assert(viommu_id);
> + g_assert(out_ptr);
> +
> + *out_ptr = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, be->fd,
> + offset);
> + if (*out_ptr == MAP_FAILED) {
> + error_setg_errno(errp, errno, "failed to mmap (size=0x%" PRIx64
> + " offset=0x%" PRIx64 ") for viommu (id=%d)",
> + size, offset, viommu_id);
> + return false;
> + }
> +
> + trace_iommufd_backend_viommu_mmap(be->fd, viommu_id, size, offset);
Like the other two APIs, maybe move the trace next to mmap() and
simplify the error_setg_errno()?
Nicolin
