> -----Original Message-----
> From: Nicolin Chen <[email protected]>
> Sent: 29 December 2025 18:40
> To: Shameer Kolothum <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Nathan Chen
> <[email protected]>; Matt Ochs <[email protected]>; Jason Gunthorpe
> <[email protected]>; [email protected];
> [email protected]; [email protected]; Krishnakant Jaju
> <[email protected]>
> Subject: Re: [RFC PATCH 01/16] backends/iommufd: Update
> iommufd_backend_get_device_info
>
> On Wed, Dec 10, 2025 at 01:37:22PM +0000, Shameer Kolothum wrote:
> > The updated IOMMUFD uAPI introduces the ability for userspace to
> > request a specific hardware info data type via IOMMU_GET_HW_INFO.
> > Update
> > iommufd_backend_get_device_info() to set
> IOMMU_HW_INFO_FLAG_INPUT_TYPE
> > when a non-zero type is supplied, and adjust all callers to pass an
> > explicitly initialised type value.
>
> Let's mention IOMMU_HW_INFO_TYPE_DEFAULT=0 v.s. just "initialized".
Ok.
>
> > +++ b/hw/vfio/iommufd.c
> > @@ -306,7 +306,7 @@ static bool
> > iommufd_cdev_autodomains_get(VFIODevice *vbasedev,
> [...]
> > bcontainer->initialized = true;
> >
> > found_container:
> > - vbasedev->cpr.ioas_id = container->ioas_id;
> > -
> > ret = ioctl(devfd, VFIO_DEVICE_GET_INFO, &dev_info);
> > if (ret) {
> > error_setg_errno(errp, errno, "error getting device info");
>
> I might have missed some details but this seems unrelated?
Yes, that is likely an artifact from a careless rebase on my side.
Thanks for catching it.
Shameer
