Re: [PATCH 10/18] target/s390x: Replace target_ulong -> vaddr in get_phys_addr_debug()

[Thomas Huth]

On 07/01/2026 14.07, Philippe Mathieu-Daudé wrote:
cpu_get_phys_page_debug() takes a vaddr argument.
Rename the @vaddr argument to avoid confusing the compiler.
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  target/s390x/helper.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/target/s390x/helper.c b/target/s390x/helper.c
index 59e1fd0c4fe..f124b16d1b3 100644
--- a/target/s390x/helper.c
+++ b/target/s390x/helper.c
@@ -68,14 +68,14 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr 
vaddr)
      return raddr;
  }
  
-hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr vaddr)
+hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr addr)

I'd maybe rather go with "v_addr" or "virt_addr" to avoid confusion with 
physical addresses here.

 Thomas