On 07/01/2026 14.08, Philippe Mathieu-Daudé wrote:
Inlining a method which use a static variable is really a bad idea, as it totally defeats the point of both concepts.Currently we have 12 + 4 = 16 static 'ccw' variables...: $ git grep -wl target/s390x/kvm/pv.h | fgrep .h hw/s390x/ipl.h $ git grep -wl target/s390x/kvm/pv.h | fgrep .c | wc -l 12 $ git grep -wl hw/s390x/ipl.h | fgrep .c | wc -l 4 Fixes: c3347ed0d2e ("s390x: protvirt: Support unpack facility") Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- target/s390x/kvm/pv.h | 24 +----------------------- target/s390x/kvm/pv.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 23 deletions(-)
Reviewed-by: Thomas Huth <[email protected]>
