On Thu, Jan 8, 2026 at 8:06 PM Markus Armbruster <[email protected]> wrote: > > Zhang Chen <[email protected]> writes: > > > As the struct IOThreadInfo definition: > > { 'struct': 'IOThreadInfo', > > 'data': {'id': 'str', > > 'thread-id': 'int', > > 'poll-max-ns': 'int', > > 'poll-grow': 'int', > > 'poll-shrink': 'int', > > 'aio-max-batch': 'int' } } > > Suggest: > > The example is incomplete: it misses members @poll-max-ns, @poll-grow, > @poll-shrink, @aio-max-batch. Messed up in commit 5fc00480ab1 > (monitor: add poll-* properties into query-iothreads result) and > commit 1793ad0247c (iothread: add aio-max-batch parameter). > > Cc: [email protected]
Nice description! I will rewrite the commit log next version. > > > Signed-off-by: Zhang Chen <[email protected]> > > --- > > qapi/misc.json | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/qapi/misc.json b/qapi/misc.json > > index 28c641fe2f..6153ed3d04 100644 > > --- a/qapi/misc.json > > +++ b/qapi/misc.json > > @@ -117,11 +117,19 @@ > > # <- { "return": [ > > # { > > # "id":"iothread0", > > -# "thread-id":3134 > > +# "thread-id":3134, > > +# 'poll-max-ns':0, > > Double quotes, please. > > The default value appears to be 32768. Maybe show that? Good catch, will fix it next version. > > > +# "poll-grow":0, > > +# "poll-shrink":0, > > +# "aio-max-batch":0 > > # }, > > # { > > # "id":"iothread1", > > -# "thread-id":3135 > > +# "thread-id":3135, > > +# 'poll-max-ns':0, > > Likewise. Yes. Thanks Chen > > > +# "poll-grow":0, > > +# "poll-shrink":0, > > +# "aio-max-batch":0 > > # } > > # ] > > # } >
