On 07/01/26, Philippe Mathieu-Daudé wrote: > 'xtensa-isa.c' is now free of target-specific symbols, > build it as common files (thus forbidding further > uses of such target-specific symbols). > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > target/xtensa/meson.build | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/target/xtensa/meson.build b/target/xtensa/meson.build > index 69c6946420a..3fdb20db655 100644 > --- a/target/xtensa/meson.build > +++ b/target/xtensa/meson.build > @@ -12,6 +12,10 @@ xtensa_ss.add(files( > 'op_helper.c', > 'translate.c', > 'win_helper.c', > +)) > + > +xtensa_common_ss = ss.source_set() > +xtensa_common_ss.add(files( > 'xtensa-isa.c', > )) > > @@ -24,4 +28,5 @@ xtensa_system_ss.add(files( > )) > > target_arch += {'xtensa': xtensa_ss} > +target_common_arch += {'xtensa': xtensa_common_ss} > target_common_system_arch += {'xtensa': xtensa_system_ss} > -- > 2.52.0 >
Mentioned this in the 7th patch, but xtensa-isa.h is strange to me, why not move hw/xtensa/xtensa-isa.h to target/ and drop the current one-line target/xtensa/xtensa-isa.h file? Also include with "target/". Otherwise, Reviewed-by: Anton Johansson <[email protected]>
