On Tue, Jan 13, 2026 at 09:30:32PM +0100, Philippe Mathieu-Daudé wrote: > On 13/1/26 20:32, Thomas Huth wrote: > > On 04/07/2025 12.14, Philippe Mathieu-Daudé wrote: > > > No need for accel-specific @dirty field when we have > > > a generic one in CPUState. > > > > > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > > > Reviewed-by: Richard Henderson <[email protected]> > > > Reviewed-by: Xiaoyao Li <[email protected]> > > > Reviewed-by: Zhao Liu <[email protected]> > > > Message-Id: <[email protected]> > > > --- > > > target/i386/nvmm/nvmm-all.c | 21 ++++++++++----------- > > > 1 file changed, 10 insertions(+), 11 deletions(-) > > > > > > diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c > > > index f1c6120ccf1..aea61a6fd2a 100644 > > > --- a/target/i386/nvmm/nvmm-all.c > > > +++ b/target/i386/nvmm/nvmm-all.c > > ... > > > @@ -982,7 +981,7 @@ nvmm_init_vcpu(CPUState *cpu) > > > } > > > } > > > - qcpu->dirty = true; > > > + qcpu->vcpu_dirty = true; > > > cpu->accel = qcpu; > > > return 0; > > > > FYI, this does not seem to compile: > > > > ../src/target/i386/nvmm/nvmm-all.c: In function 'nvmm_init_vcpu': > > ../src/target/i386/nvmm/nvmm-all.c:988:9: error: 'AccelCPUState' has no > > member named 'vcpu_dirty' > > 988 | qcpu->vcpu_dirty = true; > > | ^~ > > s/qcpu/cpu/ > > > > > Is anybody checking the netbsd builds at all? > > 3 reviewers and 6 months later. > > Should we add a policy for bitrotting untested code?
Since we don't cover netbsd in GitLab CI, all responsibility for keeping it working lies with whomever cares about the distro. No contributors or maintainers in general should feel obligated to fix bugs in untested platforms unless they specifically care about the platform. > > (I'm currently trying to update test/vm/netbsd to version 10.1, that's > > how I noticed it) MAINTAINERS lists no one against test/vm/netbsd. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
