On Thu, 31 Oct 2024 at 17:56, Paolo Bonzini <[email protected]> wrote: > > From: Dorjoy Chowdhury <[email protected]> > > Nitro Secure Module (NSM)[1] device is used in AWS Nitro Enclaves[2] > for stripped down TPM functionality like cryptographic attestation. > The requests to and responses from NSM device are CBOR[3] encoded. > > This commit adds support for NSM device in QEMU. Although related to > AWS Nitro Enclaves, the virito-nsm device is independent and can be > used in other machine types as well. The libcbor[4] library has been > used for the CBOR encoding and decoding functionalities. > > [1] https://lists.oasis-open.org/archives/virtio-comment/202310/msg00387.html > [2] https://docs.aws.amazon.com/enclaves/latest/user/nitro-enclave.html > [3] http://cbor.io/ > [4] https://libcbor.readthedocs.io/en/latest/
Hi; this commit includes a file hw/virtio/cbor-helpers.c which does not include our standard qemu/osdep.h header: > diff --git a/hw/virtio/cbor-helpers.c b/hw/virtio/cbor-helpers.c > new file mode 100644 > index 00000000000..49f55df3994 > --- /dev/null > +++ b/hw/virtio/cbor-helpers.c > @@ -0,0 +1,321 @@ > +/* > + * QEMU CBOR helpers > + * > + * Copyright (c) 2024 Dorjoy Chowdhury <[email protected]> > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or > + * (at your option) any later version. See the COPYING file in the > + * top-level directory. > + */ > + > +#include "hw/virtio/cbor-helpers.h" Is this intentional? Could we make this file include osdep.h as our standard practice requires, or would that break something? thanks -- PMM
