On 19/1/26 17:11, Tao Tang wrote:
Switch STE/CD bitfield definitions and accessors to the
'registerfields.h' REG/FIELD API.

FOLLOW-UP: Fix CTXPTR_HI/S2TTB_HI/TTB0_HI/TTB1_HI high bits width
(should be 24 bits, not 16).

Right, but ...

Signed-off-by: Tao Tang <[email protected]>
Reviewed-by: Pierrick Bouvier <[email protected]>
Reviewed-by: Eric Auger <[email protected]>
---
  include/hw/arm/smmuv3-common.h | 169 +++++++++++++++++++++++----------
  1 file changed, 120 insertions(+), 49 deletions(-)


-#define STE_VALID(x)   extract32((x)->word[0], 0, 1)
+REG32(STE_0, 0)
+    FIELD(STE_0, VALID, 0, 1)
+    FIELD(STE_0, CONFIG, 1, 3)
+    FIELD(STE_0, S1FMT, 4, 2)
+    FIELD(STE_0, CTXPTR_LO, 6, 26)
+REG32(STE_1, 4)
+    FIELD(STE_1, CTXPTR_HI, 0, 16)

... not followed up?

Reply via email to