On Tue, 27 Jan 2026 at 18:29, Mohamed Mediouni <[email protected]> wrote:
>
> Signed-off-by: Mohamed Mediouni <[email protected]>
> @@ -2143,6 +2146,9 @@ static void finalize_msi_controller(VirtMachineState
> *vms)
> }
> }
> if (vms->msi_controller == VIRT_MSI_CTRL_AUTO) {
> + if (whpx_enabled() && whpx_irqchip_in_kernel()) {
> + vms->msi_controller = VIRT_MSI_CTRL_GICV2M;
> + }
This looks like it ought to be an "else if" or some other
construct so we don't fall through into the logic below --
if we've decided we definitely want a GICV2M we can stop
making decisions about how to set vms->msi_controller.
> if (vms->gic_version == VIRT_GIC_VERSION_2) {
> vms->msi_controller = VIRT_MSI_CTRL_GICV2M;
> }
Otherwise
Reviewed-by: Peter Maydell <[email protected]>
thanks
-- PMM
