Re: [PATCH v18 13/22] whpx: interrupt controller support

[Mohamed Mediouni]

> On 29. Jan 2026, at 16:28, Peter Maydell <peter.mayd...@linaro.org> wrote:
> 
> On Tue, 27 Jan 2026 at 18:29, Mohamed Mediouni <moha...@unpredictable.fr> 
> wrote:
>> 
>> Signed-off-by: Mohamed Mediouni <moha...@unpredictable.fr>
> 
> 
> 
>> @@ -2143,6 +2146,9 @@ static void finalize_msi_controller(VirtMachineState 
>> *vms)
>>         }
>>     }
>>     if (vms->msi_controller == VIRT_MSI_CTRL_AUTO) {
>> +        if (whpx_enabled() && whpx_irqchip_in_kernel()) {
>> +            vms->msi_controller = VIRT_MSI_CTRL_GICV2M;
>> +        }
> 
> This looks like it ought to be an "else if" or some other
> construct so we don't fall through into the logic below --
> if we've decided we definitely want a GICV2M we can stop
> making decisions about how to set vms->msi_controller.
Would just doing a return; be a right way to deal with this, or converting to 
case?

Thank you,
-Mohamed
>>         if (vms->gic_version == VIRT_GIC_VERSION_2) {
>>             vms->msi_controller = VIRT_MSI_CTRL_GICV2M;
>>         }
> 
> Otherwise
> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
> 
> thanks
> -- PMM