> -----Original Message-----
> From: Nicolin Chen <[email protected]>
> Sent: 04 February 2026 19:50
> To: Shameer Kolothum Thodi <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Nathan Chen
> <[email protected]>; Matt Ochs <[email protected]>; Jason Gunthorpe
> <[email protected]>; [email protected];
> [email protected]; [email protected]; Krishnakant Jaju
> <[email protected]>
> Subject: Re: [PATCH v4 2/5] hw/arm/smmuv3-accel: Add viommu free helper
>
> On Wed, Feb 04, 2026 at 07:00:05PM +0000, Shameer Kolothum wrote:
> > Move viommu teardown into a helper function and use it from the last
> > device removal path. No functional change.
> >
> > Signed-off-by: Shameer Kolothum <[email protected]>
>
> Seems there is still only one caller by the end of the series..
Agree. This is based on one of Eric's comments on v3. I am fine either way,
keeping it as a helper or folding it back if preferred.
> Anyway,
>
> Reviewed-by: Nicolin Chen <[email protected]>
Thanks,
Shameer
